12345qiupeng
/
gtsam
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Added justification for CMake changes, with reference to this PR.

release/4.3a0
Jai Moraes 2025-01-24 13:57:50 -05:00
parent 5a02a2206a
commit 4367d94745
3 changed files with 13 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
cmake/GtsamTesting.cmake
View File

@ -242,6 +242,9 @@ macro(gtsamAddTestsGlob_impl groupName globPatterns excludedFiles linkLibraries)
set_property(SOURCE ${script_srcs} APPEND PROPERTY COMPILE_DEFINITIONS "TOPSRCDIR=\"${GTSAM_SOURCE_DIR}\"") set_property(SOURCE ${script_srcs} APPEND PROPERTY COMPILE_DEFINITIONS "TOPSRCDIR=\"${GTSAM_SOURCE_DIR}\"")
# Exclude from 'make all' and 'make install' # Exclude from 'make all' and 'make install'
# QNX is cross-compiled for, and does not support make, cmake, or ctest natively.
# Therefore, running tests must be done by manually copying test executables and required data files over.
# for more info, check PR#1968 https://github.com/borglab/gtsam/pull/1968
if(NOT QNX) if(NOT QNX)
set_target_properties(${target_name} PROPERTIES EXCLUDE_FROM_ALL ON) set_target_properties(${target_name} PROPERTIES EXCLUDE_FROM_ALL ON)
endif() endif()

5
gtsam/CMakeLists.txt
View File

@ -101,6 +101,11 @@ ENDIF(MSVC)
# Generate and install config and dllexport files # Generate and install config and dllexport files
#For config.in searches #For config.in searches
if(QNX) if(QNX)
# QNX is cross-compiled for, and does not support make, cmake, or ctest natively. Additionally, space is limited in our embedded usecase.
# Therefore, running tests must be done by manually copying test executables and required data files over, preferably avoiding
# copying the whole source tree. Thus, we set the default file lookup to the recommended test folder, with the option
# to manually change it.
# for more info, check PR#1968 https://github.com/borglab/gtsam/pull/1968
set(QNX_TARGET_DATASET_DIR "/data/home/root/qnxuser/test" CACHE STRING "Path to your on-target testing folder.") set(QNX_TARGET_DATASET_DIR "/data/home/root/qnxuser/test" CACHE STRING "Path to your on-target testing folder.")
endif() endif()
configure_file(config.h.in config.h) configure_file(config.h.in config.h)

5
gtsam/nonlinear/tests/testSerializationNonlinear.cpp
View File

@ -157,6 +157,11 @@ TEST(Serialization, NoiseModelFactor1_backwards_compatibility) {
"/../../gtsam/nonlinear/tests/priorFactor.xml", "/../../gtsam/nonlinear/tests/priorFactor.xml",
factor_deserialized_xml); factor_deserialized_xml);
#else #else
/*QNX is cross-compiled for, and does not support make, cmake, or ctest natively. Additionally, space is a large constraint on embedded systems.
* Therefore, running tests must be done by manually copying test executables and required data files over, preferably avoiding
* copying the whole source tree. Thus, we set the default file lookup to the same folder. Please copy data files to the same folder as this test.
* for more info, check PR#1968 https://github.com/borglab/gtsam/pull/1968
*/
bool c = deserializeFromXMLFile( bool c = deserializeFromXMLFile(
"priorFactor.xml", "priorFactor.xml",
factor_deserialized_xml); factor_deserialized_xml);