From 295b965b6894574c11786dbef03edc9022311d82 Mon Sep 17 00:00:00 2001
From: Varun Agrawal <varagrawal@gmail.com>
Date: Sat, 7 Dec 2024 19:09:45 -0500
Subject: [PATCH] use Assignment<Key> since it is a base class

---
 gtsam/discrete/DecisionTreeFactor.h  | 2 +-
 gtsam/discrete/DiscreteConditional.h | 2 +-
 gtsam/discrete/DiscreteFactor.h      | 2 +-
 gtsam/discrete/TableFactor.h         | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/gtsam/discrete/DecisionTreeFactor.h b/gtsam/discrete/DecisionTreeFactor.h
index bf0e23b50..688cd85a6 100644
--- a/gtsam/discrete/DecisionTreeFactor.h
+++ b/gtsam/discrete/DecisionTreeFactor.h
@@ -136,7 +136,7 @@ namespace gtsam {
     }
 
     /// Evaluate probability distribution, sugar.
-    double operator()(const DiscreteValues& values) const override {
+    double operator()(const Assignment<Key>& values) const override {
       return ADT::operator()(values);
     }
 
diff --git a/gtsam/discrete/DiscreteConditional.h b/gtsam/discrete/DiscreteConditional.h
index f59e29285..ce4fb96e5 100644
--- a/gtsam/discrete/DiscreteConditional.h
+++ b/gtsam/discrete/DiscreteConditional.h
@@ -169,7 +169,7 @@ class GTSAM_EXPORT DiscreteConditional
   }
 
   /// Evaluate, just look up in AlgebraicDecisionTree
-  double evaluate(const DiscreteValues& values) const {
+  double evaluate(const Assignment<Key>& values) const override {
     return ADT::operator()(values);
   }
 
diff --git a/gtsam/discrete/DiscreteFactor.h b/gtsam/discrete/DiscreteFactor.h
index 4470d97a7..4c1d0afb1 100644
--- a/gtsam/discrete/DiscreteFactor.h
+++ b/gtsam/discrete/DiscreteFactor.h
@@ -94,7 +94,7 @@ class GTSAM_EXPORT DiscreteFactor : public Factor {
   size_t cardinality(Key j) const { return cardinalities_.at(j); }
 
   /// Find value for given assignment of values to variables
-  virtual double operator()(const DiscreteValues& values) const = 0;
+  virtual double operator()(const Assignment<Key>& values) const = 0;
 
   /// Error is just -log(value)
   virtual double error(const DiscreteValues& values) const;
diff --git a/gtsam/discrete/TableFactor.h b/gtsam/discrete/TableFactor.h
index 8fb04fcba..497c42dc2 100644
--- a/gtsam/discrete/TableFactor.h
+++ b/gtsam/discrete/TableFactor.h
@@ -176,7 +176,7 @@ class GTSAM_EXPORT TableFactor : public DiscreteFactor {
   }
 
   /// Evaluate probability distribution, sugar.
-  double operator()(const Assignment<Key>& values) const;
+  double operator()(const Assignment<Key>& values) const override;
 
   /// Calculate error for DiscreteValues `x`, is -log(probability).
   double error(const DiscreteValues& values) const override;