12345qiupeng
/
gtsam
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #1886 from borglab/fixes

release/4.3a0
Varun Agrawal 2024-10-26 19:28:20 -04:00 committed by GitHub
parent 3d622261d7 92b3272823
commit 210e582440
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
5 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
.github/ISSUE_TEMPLATE/bug-report.md vendored
View File

@ -3,12 +3,12 @@ name: "Bug Report"
about: Submit a bug report to help us improve GTSAM about: Submit a bug report to help us improve GTSAM
--- ---
<!-- This is a channel to report bugs/issues, not a support channel to help install/use/debug your own code. We'd love to help, but just don't have the bandwidth. Please post questions in the GTSAM Google group (https://groups.google.com/forum/#!forum/gtsam-users) -->
<!--Please only submit issues/bug reports that come with enough information to reproduce them, ideally a unit test that fails, and possible ideas on what might be wrong. --> <!--Please only submit issues/bug reports that come with enough information to reproduce them, ideally a unit test that fails, and possible ideas on what might be wrong. -->
<!-- Even better yet, fix the bug and/or documentation, add a unit test, and create a pull request! --> <!-- Even better yet, fix the bug and/or documentation, add a unit test, and create a pull request! -->
<!-- This is a channel to report bugs/issues, not a support channel to help install/use/debug your own code. We'd love to help, but just don't have the bandwidth. Please post questions in the GTSAM Google group (https://groups.google.com/forum/#!forum/gtsam-users) -->
## Description ## Description
<!-- A clear description of the bug --> <!-- A clear description of the bug -->

0
containers/hub_push.sh Normal file → Executable file
View File

6
gtsam/linear/linear.i
View File

@ -733,10 +733,10 @@ virtual class BlockJacobiPreconditionerParameters : gtsam::PreconditionerParamet
#include <gtsam/linear/PCGSolver.h> #include <gtsam/linear/PCGSolver.h>
virtual class PCGSolverParameters : gtsam::ConjugateGradientParameters { virtual class PCGSolverParameters : gtsam::ConjugateGradientParameters {
PCGSolverParameters(); PCGSolverParameters();
PCGSolverParameters(gtsam::PreconditionerParameters* preconditioner); PCGSolverParameters(const gtsam::PreconditionerParameters* preconditioner);
void print(string s = ""); void print(string s = "");
gtsam::PreconditionerParameters* preconditioner; std::shared_ptr<gtsam::PreconditionerParameters> preconditioner;
}; };
#include <gtsam/linear/SubgraphSolver.h> #include <gtsam/linear/SubgraphSolver.h>

2
gtsam/nonlinear/NonlinearConjugateGradientOptimizer.h
View File

@ -146,7 +146,7 @@ double lineSearch(const S &system, const V currentValues, const W &gradient) {
double newError = system.error(newValues); double newError = system.error(newValues);
while (true) { while (true) {
const bool flag = (maxStep - newStep > newStep - minStep) ? true : false; const bool flag = (maxStep - newStep > newStep - minStep);
const double testStep = flag ? newStep + resphi * (maxStep - newStep) const double testStep = flag ? newStep + resphi * (maxStep - newStep)
: newStep - resphi * (newStep - minStep); : newStep - resphi * (newStep - minStep);

2
gtsam/nonlinear/internal/ChiSquaredInverse.h
View File

@ -36,7 +36,7 @@ namespace internal {
* @param alpha Quantile value * @param alpha Quantile value
* @return double * @return double
*/ */
double chi_squared_quantile(const double dofs, const double alpha) { inline double chi_squared_quantile(const double dofs, const double alpha) {
return 2 * igami(dofs / 2, alpha); return 2 * igami(dofs / 2, alpha);
} }