12345qiupeng
/
gtsam
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Incorporate Frank's suggestions for PR #315

release/4.3a0
Mike Sheffler 2018-09-28 00:47:17 -07:00
parent 953ff1aa05
commit 1ec15a7345
1 changed files with 3 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
tests/testGaussianBayesTreeB.cpp
View File

@ -320,21 +320,12 @@ TEST(GaussianBayesTree, shortcut_overlapping_separator)
Matrix actualJointJ = joint.augmentedJacobian(); Matrix actualJointJ = joint.augmentedJacobian();
bool Row0RhsSignsEqual = // PR 315: sign of rows in joint are immaterial
signbit(expectedJointJ(0, 2)) == signbit(actualJointJ(0, 2)); if (signbit(expectedJointJ(0, 2)) != signbit(actualJointJ(0, 2)))
if (!Row0RhsSignsEqual)
{
expectedJointJ.row(0) = -expectedJointJ.row(0); expectedJointJ.row(0) = -expectedJointJ.row(0);
}
bool Row1RhsSignsEqual = if (signbit(expectedJointJ(1, 2)) != signbit(actualJointJ(1, 2)))
signbit(expectedJointJ(1, 2)) == signbit(actualJointJ(1, 2));
if (!Row1RhsSignsEqual)
{
expectedJointJ.row(1) = -expectedJointJ.row(1); expectedJointJ.row(1) = -expectedJointJ.row(1);
}
EXPECT(assert_equal(expectedJointJ, actualJointJ)); EXPECT(assert_equal(expectedJointJ, actualJointJ));
} }