pyx class methods with arguments/return type casting

release/4.3a0
Duy-Nguyen Ta 2016-09-09 18:37:48 -04:00
parent 56c0d2a65e
commit 10f510119a
12 changed files with 131 additions and 33 deletions

View File

@ -63,13 +63,6 @@ string Argument::matlabClass(const string& delim) const {
return result + type.name();
}
/* ************************************************************************* */
bool Argument::isScalar() const {
return (type.name() == "bool" || type.name() == "char"
|| type.name() == "unsigned char" || type.name() == "int"
|| type.name() == "size_t" || type.name() == "double");
}
/* ************************************************************************* */
void Argument::matlab_unwrap(FileWriter& file, const string& matlabName) const {
file.oss << " ";
@ -109,7 +102,7 @@ void Argument::proxy_check(FileWriter& proxyFile, const string& s) const {
void Argument::emit_cython_pxd(FileWriter& file) const {
string typeName = type.qualifiedName("_");
string cythonType = typeName;
if (typeName=="Vector" || typeName == "Matrix") {
if (type.isEigen()) {
cythonType = "Map[" + typeName + "Xd]&";
} else {
if (is_ptr) cythonType = "shared_ptr[" + typeName + "]&";
@ -125,8 +118,7 @@ void Argument::emit_cython_pyx(FileWriter& file) const {
string typeName = type.pythonClassName();
string cythonType = typeName;
// use numpy for Vector and Matrix
if (typeName=="Vector" || typeName == "Matrix")
cythonType = "np.ndarray";
if (type.isEigen()) cythonType = "np.ndarray";
file.oss << cythonType << " " << name;
}
@ -134,11 +126,13 @@ void Argument::emit_cython_pyx(FileWriter& file) const {
void Argument::emit_cython_pyx_asParam(FileWriter& file) const {
string cythonType = type.cythonClassName();
string cythonVar;
if (cythonType == "Vector" || cythonType == "Matrix") {
if (type.isNonBasicType()) {
cythonVar = name + "." + type.pyxCythonObj();
if (!is_ptr) cythonVar = "deref(" + cythonVar + ")";
} else if (type.isEigen()) {
cythonVar = "Map[" + cythonType + "Xd](" + name + ")";
} else {
cythonVar = name + "." + type.pyxCythonObj();
if (!is_ptr) cythonVar = "deref(" + cythonVar + ")";
cythonVar = name;
}
file.oss << cythonVar;
}
@ -193,7 +187,7 @@ string ArgumentList::names() const {
/* ************************************************************************* */
bool ArgumentList::allScalar() const {
for(Argument arg: *this)
if (!arg.isScalar())
if (!arg.type.isScalar())
return false;
return true;
}

View File

@ -52,6 +52,9 @@ struct Argument {
/// Check if will be unwrapped using scalar login in wrap/matlab.h
bool isScalar() const;
bool isString() const;
bool isEigen() const;
bool isNonBasicType() const;
/// MATLAB code generation, MATLAB to C++
void matlab_unwrap(FileWriter& file, const std::string& matlabName) const;

View File

@ -730,21 +730,37 @@ void Class::emit_cython_pyx(FileWriter& pyxFile, const std::vector<Class>& allCl
if (parentClass) pyxFile.oss << "(" << parentClass->pythonClassName() << ")";
pyxFile.oss << ":\n";
// shared variable of the corresponding cython object
pyxFile.oss << "\tcdef " << pyxSharedCythonClass() << " " << pyxCythonObj() << "\n";
// __cinit___
pyxFile.oss << "\tdef __cinit__(self):\n"
"\t\tself." << pyxCythonObj() << " = "
<< pyxSharedCythonClass() << "(new " << pyxCythonClass() << "())\n";
pyxInitParentObj(pyxFile, "\t\tself", "self." + pyxCythonObj(), allClasses);
// cyCreateFromShared
pyxFile.oss << "\t@staticmethod\n";
pyxFile.oss << "\tcdef " << pythonClassName() << " cyCreate(" << pyxSharedCythonClass() << " other):\n"
pyxFile.oss << "\tcdef " << pythonClassName() << " cyCreateFromShared(const "
<< pyxSharedCythonClass() << "& other):\n"
<< "\t\tcdef " << pythonClassName() << " ret = " << pythonClassName() << "()\n"
<< "\t\tret." << pyxCythonObj() << " = other\n";
pyxInitParentObj(pyxFile, "\t\tret", "other", allClasses);
pyxFile.oss << "\t\treturn ret" << "\n";
// cyCreateFromValue
pyxFile.oss << "\t@staticmethod\n";
pyxFile.oss << "\tcdef " << pythonClassName() << " cyCreateFromValue(const "
<< pyxCythonClass() << "& value):\n"
<< "\t\tcdef " << pythonClassName()
<< " ret = " << pythonClassName() << "()\n"
<< "\t\tret." << pyxCythonObj() << " = " << pyxSharedCythonClass()
<< "(new " << pyxCythonClass() << "(value))\n";
pyxInitParentObj(pyxFile, "\t\tret", "ret." + pyxCythonObj(), allClasses);
pyxFile.oss << "\t\treturn ret" << "\n";
pyxFile.oss << "\n";
// Constructors
constructor.emit_cython_pyx(pyxFile, *this);
if (constructor.nrOverloads()>0) pyxFile.oss << "\n";
@ -752,14 +768,8 @@ void Class::emit_cython_pyx(FileWriter& pyxFile, const std::vector<Class>& allCl
m.emit_cython_pyx(pyxFile, *this);
if (static_methods.size()>0) pyxFile.oss << "\n";
// for(const Method& m: nontemplateMethods_ | boost::adaptors::map_values)
// m.emit_cython_pxd(pyxFile);
// for(const TemplateMethod& m: templateMethods_ | boost::adaptors::map_values)
// m.emit_cython_pxd(pyxFile);
// size_t numMethods = constructor.nrOverloads() + static_methods.size() +
// methods_.size() + templateMethods_.size();
// if (numMethods == 0)
// pyxFile.oss << "\t\tpass";
for(const Method& m: methods_ | boost::adaptors::map_values)
m.emit_cython_pyx(pyxFile, *this);
pyxFile.oss << "\n\n";
}

View File

@ -141,12 +141,10 @@ void Constructor::emit_cython_pyx(FileWriter& pyxFile, const Class& cls) const {
<< ((i > 0) ? to_string(i) : "") << "__(";
args.emit_cython_pyx(pyxFile);
pyxFile.oss << "): \n";
pyxFile.oss << "\t\treturn " << cls.cythonClassName() << ".cyCreate("
// shared_ptr[gtsam.Values](new gtsam.Values(deref(other.gtValues_))))
<< cls.pyxSharedCythonClass() << "(new "
<< cls.pyxCythonClass() << "(";
pyxFile.oss << "\t\treturn " << cls.cythonClassName()
<< ".cyCreateFromValue(" << cls.pyxCythonClass() << "(";
args.emit_cython_pyx_asParams(pyxFile);
pyxFile.oss << "))"
pyxFile.oss << ")"
<< ")\n";
}
}

View File

@ -16,6 +16,7 @@
**/
#include "Method.h"
#include "Class.h"
#include "utilities.h"
#include <boost/lexical_cast.hpp>
@ -90,3 +91,32 @@ void Method::emit_cython_pxd(FileWriter& file) const {
}
/* ************************************************************************* */
void Method::emit_cython_pyx(FileWriter& file, const Class& cls) const {
string funcName = ((name_ == "print") ? "_print" : name_);
// don't support overloads for static method :-(
size_t N = nrOverloads();
for(size_t i = 0; i < N; ++i) {
file.oss << "\tdef " << funcName;
if (templateArgValue_) file.oss << templateArgValue_->name();
file.oss << "(self";
if (argumentList(i).size() > 0) file.oss << ", ";
argumentList(i).emit_cython_pyx(file);
file.oss << "):\n";
/// Return part
file.oss << "\t\t";
if (!returnVals_[i].isVoid()) file.oss << "return ";
// ... casting return value
returnVals_[i].emit_cython_pyx_casting(file);
if (!returnVals_[i].isVoid()) file.oss << "(";
file.oss << "self." << cls.pyxCythonObj() << "." << funcName;
// if (templateArgValue_) file.oss << "[" << templateArgValue_->pyxCythonClass() << "]";
// ... argument list
file.oss << "(";
argumentList(i).emit_cython_pyx_asParams(file);
if (!returnVals_[i].isVoid()) file.oss << ")";
file.oss << ")\n";
}
}
/* ************************************************************************* */

View File

@ -22,6 +22,9 @@
namespace wrap {
// Forward declaration
class Class;
/// Method class
class Method: public MethodBase {
@ -52,6 +55,7 @@ public:
}
void emit_cython_pxd(FileWriter& file) const;
void emit_cython_pyx(FileWriter& file, const Class& cls) const;
private:

View File

@ -21,7 +21,8 @@
#include <wrap/spirit.h>
#include <string>
#include <vector>
#include <iostream>
namespace wrap {
/**
@ -109,6 +110,24 @@ public:
category = VOID;
}
bool isScalar() const {
return (name() == "bool" || name() == "char"
|| name() == "unsigned char" || name() == "int"
|| name() == "size_t" || name() == "double");
}
bool isString() const {
return name() == "string";
}
bool isEigen() const {
return name() == "Vector" || name() == "Matrix";
}
bool isNonBasicType() const {
return !isString() && !isScalar() && !isEigen();
}
public:
static Qualified MakeClass(std::vector<std::string> namespaces,
@ -166,7 +185,17 @@ public:
/// return the Cython class in pxd corresponding to a Python class in pyx
std::string pyxCythonClass() const {
return namespaces_[0] + "." + cythonClassName();
if (isNonBasicType())
if (namespaces_.size() > 0)
return namespaces_[0] + "." + cythonClassName();
else {
std::cerr << "Class without namespace: " << cythonClassName() << std::endl;
throw std::runtime_error("Error: User type without namespace!!");
}
else if (isEigen()) {
return name_ + "Xd";
} else
return name_;
}
/// the internal Cython shared obj in a Python class wrappper

View File

@ -78,4 +78,17 @@ void ReturnType::emit_cython_pxd(FileWriter& file) const {
}
/* ************************************************************************* */
void ReturnType::emit_cython_pyx_casting(FileWriter& file) const {
if (isEigen())
file.oss << "ndarray_copy";
else if (isNonBasicType()){
if (isPtr)
file.oss << pythonClassName() << ".cyCreateFromShared";
else {
file.oss << pythonClassName() << ".cyCreateFromValue";
}
}
}
/* ************************************************************************* */

View File

@ -48,6 +48,7 @@ struct ReturnType: public Qualified {
}
void emit_cython_pxd(FileWriter& file) const;
void emit_cython_pyx_casting(FileWriter& file) const;
private:

View File

@ -83,4 +83,18 @@ void ReturnValue::emit_cython_pxd(FileWriter& file) const {
}
/* ************************************************************************* */
void ReturnValue::emit_cython_pyx_casting(FileWriter& file) const {
if (isVoid()) return;
if (isPair) {
file.oss << "(";
type1.emit_cython_pyx_casting(file);
file.oss << ",";
type2.emit_cython_pyx_casting(file);
file.oss << ")";
} else {
type1.emit_cython_pyx_casting(file);
}
}
/* ************************************************************************* */

View File

@ -72,6 +72,7 @@ struct ReturnValue {
void emit_matlab(FileWriter& proxyFile) const;
void emit_cython_pxd(FileWriter& file) const;
void emit_cython_pyx_casting(FileWriter& file) const;
friend std::ostream& operator<<(std::ostream& os, const ReturnValue& r) {
if (!r.isPair && r.type1.category == ReturnType::VOID)

View File

@ -63,7 +63,7 @@ void StaticMethod::emit_cython_pxd(FileWriter& file) const {
file.oss << "\t\t@staticmethod\n";
file.oss << "\t\t";
returnVals_[i].emit_cython_pxd(file);
file.oss << name_ << ((i>0)?to_string(i):"") << "(";
file.oss << name_ << ((i>0)?"_"+to_string(i):"") << "(";
argumentList(i).emit_cython_pxd(file);
file.oss << ")\n";
}
@ -74,13 +74,14 @@ void StaticMethod::emit_cython_pyx(FileWriter& file, const Class& cls) const {
// don't support overloads for static method :-(
for(size_t i = 0; i < nrOverloads(); ++i) {
file.oss << "\t@staticmethod\n";
file.oss << "\tdef " << name_ << "(";
file.oss << "\tdef " << name_ << ((i>0)? "_" + to_string(i):"") << "(";
argumentList(i).emit_cython_pyx(file);
file.oss << "):\n";
file.oss << "\t\t";
if (!returnVals_[i].isVoid()) file.oss << "return ";
file.oss << cls.pythonClassName() << ".cyCreate("
<< cls.pyxCythonClass() << "." << name_
<< cls.pyxCythonClass() << "."
<< name_ << ((i>0)? "_" + to_string(i):"")
<< "(";
argumentList(i).emit_cython_pyx_asParams(file);
file.oss << "))\n";