Work around FindGMock/Catkin target name clash (#1011)

Handle case with multiple invocations (avoid pasting ${CMAKE_THREAD_LIBS_INIT} multiple times).
Also check if target 'gmock' already exists before building GMock to avoid failures if GMock was already
find_packaged() from another subproject.

FIXES=https://github.com/googlecartographer/cartographer_ros/issues/776
master
Juraj Oršulić 2018-03-26 12:23:32 +00:00 committed by gaschler
parent 915ebb19a6
commit ae05658ff7
1 changed files with 51 additions and 45 deletions

View File

@ -12,35 +12,36 @@
# See the License for the specific language governing permissions and # See the License for the specific language governing permissions and
# limitations under the License. # limitations under the License.
find_path(GMOCK_INCLUDE_DIRS gmock/gmock.h if(NOT GMock_FOUND)
find_path(GMOCK_INCLUDE_DIRS gmock/gmock.h
HINTS HINTS
ENV GMOCK_DIR ENV GMOCK_DIR
PATH_SUFFIXES include PATH_SUFFIXES include
PATHS PATHS
/usr /usr
) )
# Find system-wide installed gmock. # Find system-wide installed gmock.
find_library(GMOCK_LIBRARIES find_library(GMOCK_LIBRARIES
NAMES gmock_main NAMES gmock_main
HINTS HINTS
ENV GMOCK_DIR ENV GMOCK_DIR
PATH_SUFFIXES lib PATH_SUFFIXES lib
PATHS PATHS
/usr /usr
) )
# Find system-wide gtest header. # Find system-wide gtest header.
find_path(GTEST_INCLUDE_DIRS gtest/gtest.h find_path(GTEST_INCLUDE_DIRS gtest/gtest.h
HINTS HINTS
ENV GTEST_DIR ENV GTEST_DIR
PATH_SUFFIXES include PATH_SUFFIXES include
PATHS PATHS
/usr /usr
) )
list(APPEND GMOCK_INCLUDE_DIRS ${GTEST_INCLUDE_DIRS}) list(APPEND GMOCK_INCLUDE_DIRS ${GTEST_INCLUDE_DIRS})
if(NOT GMOCK_LIBRARIES) if(NOT GMOCK_LIBRARIES)
# If no system-wide gmock found, then find src version. # If no system-wide gmock found, then find src version.
# Ubuntu might have this. # Ubuntu might have this.
find_path(GMOCK_SRC_DIR src/gmock.cc find_path(GMOCK_SRC_DIR src/gmock.cc
@ -52,18 +53,23 @@ if(NOT GMOCK_LIBRARIES)
) )
if(GMOCK_SRC_DIR) if(GMOCK_SRC_DIR)
# If src version found, build it. # If src version found, build it.
if(NOT TARGET gmock)
add_subdirectory(${GMOCK_SRC_DIR} "${CMAKE_CURRENT_BINARY_DIR}/gmock") add_subdirectory(${GMOCK_SRC_DIR} "${CMAKE_CURRENT_BINARY_DIR}/gmock")
endif()
# The next line is needed for Ubuntu Trusty. # The next line is needed for Ubuntu Trusty.
set(GMOCK_INCLUDE_DIRS "${GMOCK_SRC_DIR}/gtest/include") set(GMOCK_INCLUDE_DIRS "${GMOCK_SRC_DIR}/gtest/include")
set(GMOCK_LIBRARIES gmock_main) set(GMOCK_LIBRARIES gmock_main)
endif() endif()
endif() endif()
# System-wide installed gmock library might require pthreads. # System-wide installed gmock library might require pthreads.
find_package(Threads REQUIRED) find_package(Threads REQUIRED)
list(APPEND GMOCK_LIBRARIES ${CMAKE_THREAD_LIBS_INIT}) list(APPEND GMOCK_LIBRARIES ${CMAKE_THREAD_LIBS_INIT})
endif()
include(FindPackageHandleStandardArgs) include(FindPackageHandleStandardArgs)
find_package_handle_standard_args(GMock DEFAULT_MSG GMOCK_LIBRARIES find_package_handle_standard_args(GMock DEFAULT_MSG GMOCK_LIBRARIES
GMOCK_INCLUDE_DIRS) GMOCK_INCLUDE_DIRS)
# Mitigate build issue with Catkin
set(GMOCK_FOUND FALSE)