From 55e4338468e6b1858e788453d9338fd3f3b9d241 Mon Sep 17 00:00:00 2001 From: catskul Date: Wed, 8 Nov 2017 03:07:46 -0500 Subject: [PATCH] Start cleaning up Google specific types by making them cartographer private. move string and size specific int/uint types into cartographer namespace as minimal change necessary to keep global namespace clean (#637) --- cartographer/common/configuration_files_test.cc | 2 ++ cartographer/common/port.h | 4 +++- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/cartographer/common/configuration_files_test.cc b/cartographer/common/configuration_files_test.cc index 0a2464e..3aeeeba 100644 --- a/cartographer/common/configuration_files_test.cc +++ b/cartographer/common/configuration_files_test.cc @@ -23,6 +23,8 @@ #include "cartographer/mapping/map_builder.h" #include "gtest/gtest.h" +using std::string; + namespace cartographer_ros { namespace { diff --git a/cartographer/common/port.h b/cartographer/common/port.h index c32bae4..d7e8a9e 100644 --- a/cartographer/common/port.h +++ b/cartographer/common/port.h @@ -25,6 +25,9 @@ #include #include + +namespace cartographer { + using int8 = int8_t; using int16 = int16_t; using int32 = int32_t; @@ -36,7 +39,6 @@ using uint64 = uint64_t; using std::string; -namespace cartographer { namespace common { inline int RoundToInt(const float x) { return std::lround(x); }